dvx76
commented
5 days ago if self._requests['batterycharge'].get('id', False):
timestamp = self._requests.get('batterycharge', {}).get('timestamp', datetime.now())
expired = datetime.now() - timedelta(minutes=3)
if expired > timestamp:
self._requests.get('batterycharge', {}).pop('id')
else:
raise SkodaRequestInProgressException('Charging action already in progress')If I'm not mistaken the Vehicle class keeps a map of outstanding requests by 'type' (e.g. batterycharge here) and if a previous requests is outstanding, the new request is rejected.
Prior99
Currently requests, e.g. to change the charge limit, will just queue and end up all executing. The 'problem' is that these requests can take a lot of time (10's of seconds, used to be more like minutes in the past).
E.g. if you change the charge limit to 90 and then to 80, you'll get something like this:
The old integration would cap the number of parallel requests to 1 I believe. Will try to find a reference.
We may also want to relax the poll frequency in the
set_methods (currently 15s) to avoid getting rate limited. Also wondering if we could update just the entity being (instead of everything, which I understand is whatcoordinator.async_refresh()will do.I'm also curious what the best-practice is for HA when updating number entities where the execution of the update request is high asynchronous like here.