skodaconnect / homeassistant-myskoda

Homeassistant integration for MySkoda.
19 stars 4 forks source link

HA does two updates after MQTT action finishes instead of one #70

Open WebSpider opened 2 weeks ago

WebSpider commented 2 weeks ago

Version Integration: v1.4.3 HA: 2024.10.1

Debug logs

2024-10-07 10:05:31.717 DEBUG (MainThread) [myskoda.mqtt] Waiting for operation update-charging-current complete.
2024-10-07 10:05:31.717 DEBUG (MainThread) [myskoda.rest_api] Setting reduced charging for vehicle VIN to False
2024-10-07 10:05:34.363 DEBUG (MainThread) [myskoda.mqtt] Message (operation-request) received for VIN on topic charging/update-charging-current: b'{"version":1,"operation":"update-charging-current","status":"IN_PROGRESS","traceId":"18827fcb7b6cc174a03a0d9ea2a46c76","requestId":"d41ca724-04c4-4e97-975e-b17e625d12cc"}'
2024-10-07 10:05:34.363 DEBUG (MainThread) [myskoda.mqtt] An operation 'update-charging-current' is now in progress. Trace id: 18827fcb7b6cc174a03a0d9ea2a46c76
2024-10-07 10:06:53.608 DEBUG (MainThread) [myskoda.mqtt] Message (service-event) received for VIN on topic vehicle-status/access: b'{"version":1,"traceId":"7d3ff40b-3444-49da-ac73-97243aefe48d","timestamp":"2024-10-07T08:06:52.318Z","producer":"SKODA_MHUB","name":"change-access","data":{"userId":"403cc5c0-d098-415d-8843-46ed171fd9b8","vin":"VIN"}}'
2024-10-07 10:06:53.656 DEBUG (MainThread) [myskoda.mqtt] Message (service-event) received for VIN on topic vehicle-status/access: b'{"version":1,"traceId":"df8934ef-cbdc-41f3-a381-21c51ea58449","timestamp":"2024-10-07T08:06:52.318Z","producer":"SKODA_MHUB","name":"change-access","data":{"userId":"403cc5c0-d098-415d-8843-46ed171fd9b8","vin":"VIN"}}'
2024-10-07 10:06:55.517 DEBUG (MainThread) [myskoda.mqtt] Message (service-event) received for VIN on topic vehicle-status/access: b'{"version":1,"traceId":"60232d11-eaaa-4c12-801d-72b454e7ac3c","timestamp":"2024-10-07T08:06:53.569Z","producer":"SKODA_MHUB","name":"change-access","data":{"userId":"403cc5c0-d098-415d-8843-46ed171fd9b8","vin":"VIN"}}'
2024-10-07 10:06:55.554 DEBUG (MainThread) [myskoda.mqtt] Message (service-event) received for VIN on topic vehicle-status/lights: b'{"version":1,"traceId":"7ffd1183-9dbf-40b5-bce4-25348d19704b","timestamp":"2024-10-07T08:06:53.569Z","producer":"SKODA_MHUB","name":"change-lights","data":{"userId":"403cc5c0-d098-415d-8843-46ed171fd9b8","vin":"VIN"}}'
2024-10-07 10:06:55.569 DEBUG (MainThread) [myskoda.mqtt] Message (service-event) received for VIN on topic vehicle-status/access: b'{"version":1,"traceId":"0d741697-9684-4c47-8d56-a2a3d3e8e6a4","timestamp":"2024-10-07T08:06:53.569Z","producer":"SKODA_MHUB","name":"change-access","data":{"userId":"403cc5c0-d098-415d-8843-46ed171fd9b8","vin":"VIN"}}'
2024-10-07 10:06:55.931 DEBUG (MainThread) [myskoda.mqtt] Message (service-event) received for VIN on topic vehicle-status/access: b'{"version":1,"traceId":"1edaa4df-2eb5-4830-8208-e077f0f626cc","timestamp":"2024-10-07T08:06:54.320Z","producer":"SKODA_MHUB","name":"change-access","data":{"userId":"403cc5c0-d098-415d-8843-46ed171fd9b8","vin":"VIN"}}'
2024-10-07 10:06:56.916 DEBUG (MainThread) [myskoda.mqtt] Message (service-event) received for VIN on topic vehicle-status/access: b'{"version":1,"traceId":"6a1ab4ed-4d37-4bfd-9364-8a5a88bdd89e","timestamp":"2024-10-07T08:06:54.320Z","producer":"SKODA_MHUB","name":"change-access","data":{"userId":"403cc5c0-d098-415d-8843-46ed171fd9b8","vin":"VIN"}}'
2024-10-07 10:07:05.655 DEBUG (MainThread) [myskoda.mqtt] Message (operation-request) received for VIN on topic charging/update-charging-current: b'{"version":1,"operation":"update-charging-current","status":"COMPLETED_SUCCESS","traceId":"a2d6188ae6716be4191fa437c2be76cb","requestId":"d41ca724-04c4-4e97-975e-b17e625d12cc"}'
2024-10-07 10:07:05.655 DEBUG (MainThread) [myskoda.mqtt] Operation 'update-charging-current' for trace id 'a2d6188ae6716be4191fa437c2be76cb' completed.
2024-10-07 10:07:05.655 DEBUG (MainThread) [myskoda.mqtt] Resolving listener for operation 'update-charging-current'.
2024-10-07 10:07:05.655 INFO (MainThread) [custom_components.myskoda.switch] Reduced current limit disabled.
2024-10-07 10:07:23.610 DEBUG (MainThread) [custom_components.myskoda.coordinator] Updating full vehicle for VIN
2024-10-07 10:07:29.003 DEBUG (MainThread) [custom_components.myskoda.coordinator] Manually updated myskoda data
2024-10-07 10:07:35.656 DEBUG (MainThread) [custom_components.myskoda.coordinator] Updating charging information for VIN
2024-10-07 10:07:37.912 DEBUG (MainThread) [custom_components.myskoda.coordinator] Manually updated myskoda data
WebSpider commented 2 weeks ago

This is most likely due to the logic behind the access-updates here: https://github.com/skodaconnect/homeassistant-myskoda/blob/b4e4155acd95ab4b0abcc351c0f50bfea8a45a02/custom_components/myskoda/coordinator.py#L155