search

skodaconnect / homeassistant-skodaconnect

Skoda Connect - A home assistant plugin to add integration with your car
Apache License 2.0
232 stars 28 forks source link

Unreliable location (North Pole) #233

Open luc-ass opened 1 year ago

luc-ass commented 1 year ago

Describe the bug The API seems to return unreliable location data under some circumstances. In my case it reports lat 0, long 0 latitude: 134.217726, longitude: -161.061275 if I park my car (Superb 3V) in one specific underground garage. This causes to look really funny on the map card.

**Is this working in MySkoda app?*** Location history is not visible within the app

Latest working release As far as I know, this was always the case

Debug logs If applicable, add debug logs. See README on how to enable debug logs with response debugging.

Installation:

Additional context This is what it looks like: Bildschirmfoto 2023-11-08 um 10 03 30

Perhaps implausible data can be ignored to improve on this? If you let me know where to look for the location processing, I'd happily create a pull request.

WebSpider commented 1 year ago

You seem to be able to reproduce this quite easily. Can you see what the state of the device tracker for your car is?

HA > Dev tools >States > filter the device tracker > state attribute yaml

luc-ass commented 1 year ago

I'll check on it when doing groceries next week. Anything else that should be logged?

luc-ass commented 12 months ago

Okay, I caught it:

source_type: gps
latitude: 134.217726
longitude: -161.061275
gps_accuracy: 0
model: Škoda Superb Combi Style/2017-11-10
entity_picture: https://ip-modcwp.azureedge.net/xxxxxxxxxxxxx_front1080.png
assumed_state: true
icon: si:skoda
friendly_name: Skoda Superb Position

Looks like gps_accuracy: 0 is a good indicator on whether to use the information or discard it.

WebSpider commented 12 months ago

Okay, I caught it:

source_type: gps
latitude: 134.217726
longitude: -161.061275
gps_accuracy: 0
model: Škoda Superb Combi Style/2017-11-10
entity_picture: https://ip-modcwp.azureedge.net/xxxxxxxxxxxxx_front1080.png
assumed_state: true
icon: si:skoda
friendly_name: Skoda Superb Position

Looks like gps_accuracy: 0 is a good indicator on whether to use the information or discard it.

Thanks a lot! This will make it easier to fix this 👍

github-actions[bot] commented 10 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

luc-ass commented 10 months ago

This is still active