skodaconnect / homeassistant-skodaconnect

Skoda Connect - A home assistant plugin to add integration with your car
Apache License 2.0
232 stars 28 forks source link

No longer able to rename vehicle #65

Closed kekonn closed 3 years ago

kekonn commented 3 years ago

Describe the bug After the latest upgrade the integration no longer respects the names set in the yaml config and there is no config flow rename method.

Latest working release Not sure, but it did work shortly after the config flow introduction.

Debug logs Unfortunately no debug logs enable yet (will post later), but I do see a lot of 403 codes in the core log

21-09-02 08:20:28 WARNING (MainThread) [skodaconnect.connection] Something went wrong when refreshing VW-Group API tokens. <!doctype html><html lang="en"><head><title>HTTP Status 403 – Forbidden</title><style type="text/css">body {font-family:Tahoma,Arial,sans-serif;} h1, h2, h3, b {color:white;background-color:#525D76;} h1 {font-size:22px;} h2 {font-size:16px;} h3 {font-size:14px;} p {font-size:12px;} a {color:black;} .line {height:1px;background-color:#525D76;border:none;}</style></head><body><h1>HTTP Status 403 – Forbidden</h1><hr class="line" /><p><b>Type</b> Status Report</p><p><b>Message</b> Access Denied</p><p><b>Description</b> The server understood the request but refuses to authorize it.</p><hr class="line" /><h3>Apache Tomcat</h3></body></html>

Installation:

Additional context N/A

Farfar commented 3 years ago

There's no need for this any longer since renaming is part of the functionality for config flow integrations in Home Assistant. The name is whatever you have set in the app.

image Click on the device.

image Click on the name of your device.

image Click on the pencil next to the name of the device. Enter whatever you want and it will change the name of all entities for that device.

kekonn commented 3 years ago

While that is good news on it's own, I'm afraid that mechanism doesn't seem to be working.

image

Farfar commented 3 years ago

While that is good news on it's own, I'm afraid that mechanism doesn't seem to be working.

Strange, works a treat for me. image

image

image Important: press rename here.

image

If you for some reason don't press "rename", it won't rename entities. Then you will need to rename them manually.

kekonn commented 3 years ago

I never even got that question about the rename. Because it already thinks it has the correct name. I might have to try adding another space or something.

Op do 2 sep. 2021 om 14:07 schreef Kim @.***>:

While that is good news on it's own, I'm afraid that mechanism doesn't seem to be working.

Strange, works a treat for me. [image: image] https://user-images.githubusercontent.com/1235384/131840488-e32b369a-7edf-44ea-8579-faab37ede786.png

[image: image] https://user-images.githubusercontent.com/1235384/131840521-7ad32034-f334-4ddf-a8d1-e2ed0ab277e4.png

[image: image] https://user-images.githubusercontent.com/1235384/131840557-2d55cb99-40df-4603-94d3-3eddd5de70d8.png Important: press rename here.

[image: image] https://user-images.githubusercontent.com/1235384/131840605-14e7424c-e1b7-44ba-98c6-f1f1323f51f9.png

If you for some reason don't press "rename", it won't rename entities. Then you will need to rename them manually.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lendy007/homeassistant-skodaconnect/issues/65#issuecomment-911600621, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABERJS2WU46KVA76G4JPSLT75SJXANCNFSM5DIOLWWA .

Farfar commented 3 years ago

I never even got that question about the rename. Because it already thinks it has the correct name. I might have to try adding another space or something. Op do 2 sep. 2021 om 14:07 schreef Kim @.***>: While that is good news on it's own, I'm afraid that mechanism doesn't seem to be working. Strange, works a treat for me. [image: image] https://user-images.githubusercontent.com/1235384/131840488-e32b369a-7edf-44ea-8579-faab37ede786.png [image: image] https://user-images.githubusercontent.com/1235384/131840521-7ad32034-f334-4ddf-a8d1-e2ed0ab277e4.png [image: image] https://user-images.githubusercontent.com/1235384/131840557-2d55cb99-40df-4603-94d3-3eddd5de70d8.png Important: press rename here. [image: image] https://user-images.githubusercontent.com/1235384/131840605-14e7424c-e1b7-44ba-98c6-f1f1323f51f9.png If you for some reason don't press "rename", it won't rename entities. Then you will need to rename them manually. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#65 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABERJS2WU46KVA76G4JPSLT75SJXANCNFSM5DIOLWWA .

If I were you I would remove and add the integration again.

kekonn commented 3 years ago

Well this is getting more odd by the minute. I readded the integration and it picked up the correct name without me doing anything but this time it also put the name on all the entities.

Farfar commented 3 years ago

Well this is getting more odd by the minute. I readded the integration and it picked up the correct name without me doing anything but this time it also put the name on all the entities.

Probably something hindering the integration from changing the name. Happens sometimes when there's old data in HA.

kekonn commented 3 years ago

I'm just happy I don't have to redo an entire tab on my dashboard. Case closed as far as I'm concerned!