skodaconnect / myskoda

Python library for interacting with MySkoda APIs.
MIT License
2 stars 2 forks source link

Code quality things #1

Closed dvx76 closed 1 week ago

dvx76 commented 1 week ago

I like to start with all rules enabled and then disable anything we agree are overly pedantic or unnecessary.

Fix any remaining findings in the code. Mostly line length and type annotations.

100% open for discussion.

WebSpider commented 1 week ago

Oh yeah, I fully agree with this approach! Did a few inline remarks, nothing huge.

Prior99 commented 1 week ago

Merged this! The only thing that I added was pydantic to authorization.py

Prior99 commented 1 week ago

Thank you for the good work :)