Adjust PredictiveMaintenanceSettings

skodaconnect / myskoda

Python library for interacting with MySkoda APIs.

MIT License

9 stars 22 forks source link

Adjust PredictiveMaintenanceSettings #39

Closed OBerghmans closed 2 months ago

OBerghmans commented 2 months ago

Make phone and preferred_channel optional in predictive maintenance setting:

Phone is not always filled in. Fixes my issue (https://github.com/skodaconnect/homeassistant-myskoda/issues/34)
Preferred Channel is also not always present. Fixes issue (https://github.com/skodaconnect/homeassistant-myskoda/issues/33)

Also made the "phone" print nicer when using the CLI (prints a "-" instead of None)

OBerghmans commented 2 months ago

Linting fails on the scripts directory. I can add the new line at the end of the python script, but I don't know how you would like to solve the namespace-packages finding.

dvx76 commented 2 months ago

Linting fails on the scripts directory. I can add the new line at the end of the python script, but I don't know how you would like to solve the namespace-packages finding.

Not something you touched in this PR so no concern. It's just been fixed in another PR anyway I think. Thanks for contributing!