search

skogsaas / homey.dashboards

https://homeyboard.vercel.app
6 stars 0 forks source link

INsights: zeroline in line graph #76

Open Zakraket opened 1 year ago

Zakraket commented 1 year ago

In a line graph (insights) it's difficult to see if the line is above or below zero when no background color is used. In a bar-graph this is very visible

Maybe add a (darkgrey?) line for zero?

skogsaas commented 1 year ago

You mind showing me a case like this? 🤔

Zakraket commented 1 year ago

Sure, see the same graph, values near or around zero; the exact value is hard to read, but the bargraph at least shows better that the value is at least above zero than the linegraph. Schermafbeelding 2023-10-05 134949 Schermafbeelding 2023-10-05 135012

With a fillcolor it's better because the fill is upsidedown when below zero Schermafbeelding 2023-10-05 135357

On Homey insights it's worse, because they "fill" the whole graph like it's above zero Schermafbeelding 2023-10-05 135317

Just a thicker or lighter line on the zero-value would make it beteter I think

Hope this explains

skogsaas commented 1 year ago

As the graph is generated by Chart.JS, I'm not sure if this is something I can do anything with. And I'm unsure how this should be handled, as with your graphs the range is from -2000 to +2000, which could have a thick line for 0. But for a temperature sensor measuring indoor temperature the range would typically be 10 to 40 degrees. How should the line be handled then?

Zakraket commented 1 year ago

In that case no line would be fine imo

But if it’s too difficult or too much work there are maybe easier wins 😊 the fact that these graphs invert the fill (unlike on Homey insights) makes it better at least

Van: Marcus @.> Verzonden: donderdag 5 oktober 2023 14:08 Aan: skogsaas/homey.dashboards @.> CC: Zakraket @.>; Author @.> Onderwerp: Re: [skogsaas/homey.dashboards] INsights: zeroline in line graph (Issue #76)

As the graph is generated by Chart.JS, I'm not sure if this is something I can do anything with. And I'm unsure how this should be handled, as with your graphs the range is from -2000 to +2000, which could have a thick line for 0. But for a temperature sensor measuring indoor temperature the range would typically be 10 to 40 degrees. How should the line be handled then?

— Reply to this email directly, view it on GitHubhttps://github.com/skogsaas/homey.dashboards/issues/76#issuecomment-1748753674, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQ5W2RWJZYA4S4Z4OZLI7D3X52PJHAVCNFSM6AAAAAA5T4KVKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBYG42TGNRXGQ. You are receiving this because you authored the thread.Message ID: @.**@.>>