search

skohub-io / skohub-blog

https://blog.skohub.io
Apache License 2.0
0 stars 1 forks source link

Publish blog with GitHub pages #3

Closed acka47 closed 3 years ago

acka47 commented 3 years ago

See https://www.gatsbyjs.com/docs/how-to/previews-deploys-hosting/how-gatsby-works-with-github-pages/ for instructions on how to use gatsby with GitHub pages.

I think, we should

Functional review: @acka47 Code review: @fsteeg

acka47 commented 3 years ago

We decided to first publish to https://skohub-io.github.io and then set up the reverese proxy in a next step.

dr0i commented 3 years ago

@dr0i :

Asked IT to resolve blog.skohub.io to emphytos.

dr0i commented 3 years ago

Configured as proxy, note the missing certificate. While it looks ok, it is not: look in the browser's dev console for missing files. E.g. the file https://blog.skohub.io/skohub-blog/favicon-32x32.png?v=91b1901e405e1500f9b7569b85f1ad60 is missing while it works leaving out the /skohub-blog, see https://blog.skohub.io/favicon-32x32.png?v=91b1901e405e1500f9b7569b85f1ad60 . That's because of the proxy. It would be fixed if we could assure https://skohub-io.github.io/ to work (as claimed in https://github.com/skohub-io/skohub-blog/issues/3#issuecomment-905372910), not https://skohub-io.github.io/skohub-blog/ as it is atm.

dr0i commented 3 years ago

note to self: may be the same problem as in https://github.com/metafacture/metafacture-playground/issues/27. Check that out.

dr0i commented 3 years ago

@acka47 forked, branched and deployed to my pages to test the setup. I think it's fine now with the pathPrefix removed. If you check the links: they lack the "/skohub-blog part.

dr0i commented 3 years ago

Also configured this setup into the proxy - test it : https://blog.skohub.io/ .

acka47 commented 3 years ago

Looks fine. The rel=canonical links should be configured differently, though. Currently they are pointing to GitHub pages, e.g. at https://blog.skohub.io/2020-10-09-skohub-apconf/: <link rel="canonical" href="https://skohub-io.github.io/skohub-blog/2020-10-09-skohub-apconf/". This should be <link rel="canonical" href="https://blog.skohub.io/2020-10-09-skohub-apconf/" instead. Maybe we could use https://www.gatsbyjs.com/plugins/gatsby-plugin-canonical-urls/ for this. Assigning @katauber .

katauber commented 3 years ago

Looks fine. The rel=canonical links should be configured differently, though. Currently they are pointing to GitHub pages, e.g. at https://blog.skohub.io/2020-10-09-skohub-apconf/: <link rel="canonical" href="https://skohub-io.github.io/skohub-blog/2020-10-09-skohub-apconf/". This should be <link rel="canonical" href="https://blog.skohub.io/2020-10-09-skohub-apconf/" instead. Maybe we could use https://www.gatsbyjs.com/plugins/gatsby-plugin-canonical-urls/ for this. Assigning @katauber .

This plugin is already installed, I will adjust the gatsby-conf.js to the right url.

dr0i commented 3 years ago

Merged #6 into main to trigger a rebuild of the pages. Reopening this issue for functional review.

dr0i commented 3 years ago

Hm , wait @acka47 with your review, it seems like the canonical links are not fixed yet. Investigating...

dr0i commented 3 years ago

(Proxy was set to my dr0i test repo. Ok to review now @acka47

acka47 commented 3 years ago

+1 Looks good to me. We will announce the blog as soon as the SSL certificate is installed. (You could also sign it in a video conference and then bring it to hbz next week, @dr0i .)

dr0i commented 3 years ago

Installed SSL certifictates. You may want to ckeck @acka47 .

acka47 commented 3 years ago

+1 Looks good. Unfortunately, hypothes.is annotations are not shown at neither of the blogs now. I opened another issue for this at #7 .

acka47 commented 3 years ago

Closing.