search

skohub-io / skohub-blog

https://blog.skohub.io
Apache License 2.0
0 stars 1 forks source link

3 publish blog #6

Closed dr0i closed 3 years ago

dr0i commented 3 years ago

Publish under root level.

See #3.

dr0i commented 3 years ago

@katauber see my own code comment where I asked about advice and: the package-lock.json is now huge (~2 MB) - is this ok?

katauber commented 3 years ago

@katauber see my own code comment where I asked about advice and: the package-lock.json is now huge (~2 MB) - is this ok?

I think the size itself is no problem but what I don't understand why it is so much bigger than before (from ~ 21000 lines to 46000 lines). Maybe the reason is that I use lockfile version 1 (npm v6) and you used lockfile version 2 (npm v7), see https://stackoverflow.com/questions/11414392/git-diff-thinks-the-last-line-of-the-file-has-been-moved-after-the-end-of-file. If that is the reason I think it's ok. I will update my npm version to v7 and see what happens with the package-lock.json.

dr0i commented 3 years ago

The cause of the huge package-json.lock seems indeed because of lockfile version 2.

katauber commented 3 years ago

Sorry, I wanted to link this url https://docs.npmjs.com/cli/v7/configuring-npm/package-lock-json#lockfileversion in my last comment. That makes more sense.

The cause of the huge package-json.lock seems indeed because of lockfile version 2.

👍

dr0i commented 3 years ago

there should a recommendation of npm version (7?) in the README.

There is already a note in the README ( nvm use 15 ), I think that make me build it using lockfile version 2. So we can leave it as it is.