search

skohub-io / skohub-editor

Apache License 2.0
5 stars 4 forks source link

Fix TypeError on empty translate key #52

Closed literarymachine closed 3 years ago

literarymachine commented 3 years ago

Fixes #51, or rather the underlying bug.

dr0i commented 3 years ago

Hm, I cannot reproduce the problem, i.e. when I click on 'publish' just nothing happens (besides the first two mandatory fields turning red (validation process?)). Deploying this PR to test (https://test.skohub.io/editor/) doesn't change anything. I probably miss something.

acka47 commented 3 years ago

@dr0i This is probably because the default schema has been updated in the meantime see https://github.com/dini-ag-kim/lrmi-profile/commit/6452adb5704962e7fbf0ccc8ab0e03944555a3ff. For testing this you should use this schema: https://raw.githubusercontent.com/dini-ag-kim/lrmi-profile/7aae393f58ebfa4a1e7c3c8f87ecc041f2a9747b/draft/schemas/schema.json

dr0i commented 3 years ago

@acka47 ah - thx this did the trick :) Getting no more blank side but now I get an Error.oneOf a the top of the side after clicking publish on the test instance with the deployed fix. I guess that is intended?

dr0i commented 3 years ago

Deployd to test and production, closed.