search

skohub-io / skohub-shapes

4 stars 2 forks source link

1 no link to concept scheme #2

Closed sroertgen closed 1 year ago

sroertgen commented 1 year ago

I removed the shape in question and also added basic test functionality for the shape.

See https://github.com/skohub-io/shapes/tree/1-no-link-to-concept-scheme#tests for my idea of testing the shape.

sroertgen commented 1 year ago

I just came across this SHACL Test Suite report: https://w3c.github.io/data-shapes/data-shapes-test-suite/

If we would like to dig deeper into testing this shape, this might be an interesting option.

sroertgen commented 1 year ago

They are indeed identical. My idea (that I apparently did not write down) was that maybe a test file is added per shape to test that shape. So OrpahnConcepts.ttl should be the data to test the :OrphanConcepts shape and ConceptShape.ttl would be the data to test :ConceptShape.

acka47 commented 1 year ago

It would probably reduce possible misunderstanding when the "Error" notes in by the test.sh script would include the filename where the error occured insteadof just "Error: This should be invalid, but is valid" referring to the previous line. (I at least was unsure to what this refers in the first try.)

sroertgen commented 1 year ago

That's a good point. I added the filename to the error message.