search

skohub-io / skohub-shapes

4 stars 2 forks source link

Refactor command line script #5

Closed nichtich closed 12 months ago

sroertgen commented 12 months ago

Thank you very much! That looks very good.

Just out of curiosity before the merge (because I'm not that fluent in bash as you might have noticed): Is it best practice to remove the file extension, because of the shebang?

If yes, then why not do the same for scripts/test.sh ?

nichtich commented 12 months ago

Is it best practice to remove the file extension, because of the shebang?

Not for plain shell-scripts but validate-skos is going to be used as plain command (if put into PATH) so better not hard-code its programming language.

because I'm not that fluent in bash as you might have noticed

On average I also need to search for specific syntax/method every 10 to 20 new lines of Bash!

nichtich commented 12 months ago

I should note that the script does not work without option -o with docker when docker is installed via snap because of a bug in this version of docker.