search

skohub-io / skohub-vocabs

A lightweight tool to publish SKOS Vocabularies
https://skohub.io/
Apache License 2.0
34 stars 25 forks source link

Support related and related match #117

Closed sroertgen closed 3 years ago

sroertgen commented 3 years ago

Based on #106 I also added skos:relatedMatch.

This will close #109 #105 ~#116~.

acka47 commented 3 years ago

@dr0i, can you please deploy this on test?

dr0i commented 3 years ago

Branch has conflicts, please resolve them first.

acka47 commented 3 years ago

Ah, @sroertgen already said that he could resolve them. Assigning him.

sroertgen commented 3 years ago

I'm sorry I accidentally merged into master directly.

acka47 commented 3 years ago

@dr0i, can you please deploy master on test?

dr0i commented 3 years ago

Deployed at test.

acka47 commented 3 years ago

Deployed at test.

Are you sure? I published https://github.com/acka47/hcrt/blob/master/hcrt.ttl to test and it has matching relations as wll as related in there but I can not see them in https://test.skohub.io/acka47/hcrt/heads/master/w3id.org/kim/hcrt/scheme.de.html – neither in the HTML nor in the JSON...

dr0i commented 3 years ago

Yes , with 5ce5f05 as the HEAD:

commit 5ce5f05d9d37020c0a9836dae55c5bd741325abc (HEAD -> master, origin/relatedMatch, origin/master, origin/HEAD)

Just redeployed it, without your desired outcome. The scripts/start.sh is used, maybe there is a flaw in it? I also did now rm -rf .cache as suggested in the README before running the start script, but this changes nothing. And: is this working at production or is only test affected?

acka47 commented 3 years ago

Now it looks good, see https://test.skohub.io/acka47/hcrt/heads/master/w3id.org/kim/hcrt/text.de.html. Will start my review then.

dr0i commented 3 years ago

@acka47 just to deconfuse me , you wrote:

as related in there but I can not see them in https://test.skohub.io/acka47/hcrt/heads/master/w3id.org/kim/hcrt/scheme.de.html

and I still cannot see these related. What do I miss?

acka47 commented 3 years ago

and I still cannot see these related. What do I miss?

It's there now, see https://test.skohub.io/acka47/hcrt/heads/master/w3id.org/kim/hcrt/text.de.html

dr0i commented 3 years ago

I see it's in text.de.html but is is in scheme.de.html ?

acka47 commented 3 years ago

I see it's in text.de.html but is is in scheme.de.html ?

I was a bit unclear in https://github.com/skohub-io/skohub-vocabs/pull/117#issuecomment-762218843. i referred to the concept scheme (scheme) but the changes can only be seen for concepts in that scheme (e.g. text).

literarymachine commented 3 years ago

The links are there, but they are broken. They should point to the current language, e.g. slide.de.html.

sroertgen commented 3 years ago

ah yes, the changes from i18n are not reflected there. This should be easy to fix. I guess we proceed in master? I can prepare the fix.

acka47 commented 3 years ago

I guess we proceed in master?

+1

sroertgen commented 3 years ago

See: a92b32324f3415b0520382afb9c9824275648b75

acka47 commented 3 years ago

@dr0i please redeploy on test.

dr0i commented 3 years ago

Deployed (as always by just doing this: killing the process - and wait for monit to kick in to execute start script).

acka47 commented 3 years ago

Everything's fine now, please deploy to production, @dr0i .

dr0i commented 3 years ago

Deployed to production.