search

skohub-io / skohub-vocabs

A lightweight tool to publish SKOS Vocabularies
https://skohub.io/
Apache License 2.0
34 stars 25 forks source link

Support skos:example #124

Closed acka47 closed 3 years ago

acka47 commented 3 years ago

Requirement by IBI for "Klassifikation für interdisziplinäre Forschungsfelder", sent by V.P. via email (to @acka47 & @sroertgen) today (2021-01-28).

sroertgen commented 3 years ago

How do we want handle skos:example? I think SKOS allows multiple examples per language (which I guess makes sense). Though for other documentation properties, e.g. skos:scopeNote or skos:definition, we right now only support one value per language (where SKOS would also allow more than one).

acka47 commented 3 years ago

Good question. You mean whether we should use an array here, right? As skos::example is a subproperty of skos:note we should treat it the same. The use case comes from https://github.com/KDSF-FFK/KDSF-FFK/blob/main/FFK.ttl where several examples are listed in one string and not separate ones. This is in line with our current approach to skos:note.

sroertgen commented 3 years ago

[...] You mean whether we should use an array here, right?

Yes.

As skos::example is a subproperty of skos:note we should treat it the same. [...] This is in line with our current approach to skos:note.

I think we currently only allow one language per value:

https://github.com/skohub-io/skohub-vocabs/blob/4bd7051d3cdb34d422a74d801ac45d264f8cfe6b/src/context.js#L45-L53

The only exception is skos:altLabel:

https://github.com/skohub-io/skohub-vocabs/blob/4bd7051d3cdb34d422a74d801ac45d264f8cfe6b/src/context.js#L42-L44

I just made a quick test with two skos:definition of same language and it did not work, no definition at all showed up though it did build successfully.

sroertgen commented 3 years ago

Ah sorry. I got it wrong. Yes, one long string per language is totally fine. And it is in line with the current approach.

dr0i commented 3 years ago

PR is merged, but this issue is not closed automatically, while I think it could be closed. As it is unassigned, I hereby assign it to @acka47 who inititated the issue.