skohub-io / skohub-vocabs

A lightweight tool to publish SKOS Vocabularies
https://skohub.io/
Apache License 2.0
34 stars 25 forks source link

Not all skos:prefLabels are indexed in FlexSearch #127

Closed acka47 closed 2 years ago

acka47 commented 3 years ago

Taking a deeper look at the FlexSearch index of some vocabularies, I noticed that not all skos:prefLabels are indexed. In HCRT, I found that "Abbildung" from https://w3id.org/kim/hcrt/image isn't indexed:

image

literarymachine commented 3 years ago

image

Confirmed, it looks like the problem is that one language overwrites the others.

sroertgen commented 3 years ago

What is the wanted behaviour here? Do we also want to show results if search term was in another language? There maybe two options:

  1. Show Concepts even if the search term is another language:

Screenshot 2021-09-02 at 10 19 43 Screenshot 2021-09-02 at 10 19 54

  1. Only show results for the given language:

Screenshot 2021-09-02 at 10 27 50 Screenshot 2021-09-02 at 10 27 56

I think the first approach might be a bit confusing for users, but I'm open for discussion and feedback.

acka47 commented 3 years ago

We should also consider #128 ("Add strings from skos:altLabel & skos:example to FlexSearch index") in this discussion as implementing it might also lead to showing a concept label as result that does not match the search term. When broadening the context like this, I also see two options:

  1. Show concepts if the search term matches prefLabel, altLabel or example in the chosen language. (The question why this concept is shown as result will then be answered when clicking on the link where altLabels and examples are shown.)
  2. Show concepts if the search term matches prefLabel, altLabel or example in any language.

I think, here, the first approach makes more sense, i.e. to even show a concept when the search term matches its prefLabel, altLabel or example in the given language.

This would mean, for this issue, to chose your second approach from https://github.com/skohub-io/skohub-vocabs/issues/127#issuecomment-911383856 which you already favoured.

dr0i commented 2 years ago

I think the vocab has to be rebuild to become effective?

acka47 commented 2 years ago

I rebuilt HCRT and Hochschulfächersystematik. Closing.