search

skohub-io / skohub-vocabs

A lightweight tool to publish SKOS Vocabularies
https://skohub.io/
Apache License 2.0
34 stars 25 forks source link

142 alt labels #149

Closed sroertgen closed 3 years ago

sroertgen commented 3 years ago

I added altLabels to be displayed on a Concepts page as requested in #142.

This will close #142.

acka47 commented 3 years ago

Looks good locally. However, as with the last PRs, I'd like to review this on the test system. For @dr0i to deploy this to test, the one failing check needs to be fixed. Assigning @sroertgen to have a look at this.

sroertgen commented 3 years ago

checks have passed now. I just reran the tests. It failed the first time due to some network issues I guess.

acka47 commented 3 years ago

@dr0i Please deploy to test.

dr0i commented 3 years ago

Deployed, but I can't see e.g. "Heimatunterricht" at https://test.skohub.io/dini-ag-kim/schulfaecher/heads/main/w3id.org/kim/schulfaecher/s1028.de.html, so probably it's not deployed correctly?

acka47 commented 3 years ago

Deployed, but I can't see e.g. "Heimatunterricht" at https://test.skohub.io/dini-ag-kim/schulfaecher/heads/main/w3id.org/kim/schulfaecher/s1028.de.html, so probably it's not deployed correctly?

A new build has to be triggered first and then we'll see whether it works.

acka47 commented 3 years ago

+1 Looks good, see https://test.skohub.io/dini-ag-kim/schulfaecher/heads/skohubTest/w3id.org/kim/schulfaecher/s1028.de.html. Please deploy to production, @dr0i .

dr0i commented 3 years ago

Deployed to production, closed. You may need to rebuild the vocabs at production then to show these alt labels?

acka47 commented 3 years ago

You may need to rebuild the vocabs at production then to show these alt labels?

Yes