Closed acka47 closed 1 year ago
Umlauts now don't work in a different way than before:
Theay are apparantly not ignored anymore but transformed to their corresponding vowel:
As mentioned in https://github.com/skohub-io/skohub-vocabs/pull/197#issue-1326736011 Uppercase umlaute should now work.
Theay are apparantly not ignored anymore but transformed to their corresponding vowel:
This is still the case and requires some adjustments in either App.js
or the nestedList.js
component. So #197 will not close this issue. But it will bring some improvement.
Functional review for #197:
As @sroertgen says, this is an improvement as upper case Umlauts now also work (I noticed that my "Über" example in https://github.com/skohub-io/skohub-vocabs/issues/164#issuecomment-1202724985 isn't a good one as there eists no "Über" in the Hochschulfächerklassifikation):
The change from #197 can be deployed to production, I will open a PR against the master. Otherwise I agree with @sroertgen that this will need some more work to close the issue by handling Umlaute correctly.
Reopening as #197 doesn't completely fix the problem (see above two comments by me and @sroertgen ).