skohub-io / skohub-vocabs

A lightweight tool to publish SKOS Vocabularies
https://skohub.io/
Apache License 2.0
34 stars 25 forks source link

Support language tags other than @de #24

Closed acka47 closed 5 years ago

acka47 commented 5 years ago

Today, I published the Educational Subject Classification (ESC) via SkoHub. Everything went fine regarding the process (pushing int eh GitHub master and updating SkoHub via webhook).

For labels to be shown, I had to replace @en tags by de`, see https://github.com/acka47/skos/commit/b791afbd891e8e96fa9cccfdc6489ed71bf419e4

literarymachine commented 5 years ago

Our usage of JSON-LD language maps is reflected in the GraphQL schema we use in Gatsby. This means that we have to list every single supported language as a valid property. We could get around this by not using language maps and simply allow any string as values for @language. This way, we would simply support any language tags. Otherwise we would need a list of languages. The IANA Language Subtag Registry would probably be right source.

literarymachine commented 5 years ago

For labels to be shown, I had to replace @en tags

Support for @en added in https://github.com/hbz/skohub-ssg/pull/28/commits/dafe1d6166a4a9ebc8779d57edc4a482e2306751.

literarymachine commented 5 years ago

@acka47 ae488bd adds support for all language tags.

acka47 commented 5 years ago

+1 I tested it, and it works fine, see https://test.skohub.io/acka47/skos/w3id.org/class/esc/scheme.html.