skohub-io / skohub-vocabs

A lightweight tool to publish SKOS Vocabularies
https://skohub.io/
Apache License 2.0
32 stars 25 forks source link

Include skos:definition in search index #267

Closed carlschuurbiers closed 11 months ago

carlschuurbiers commented 11 months ago

It would be practical for the search function to also search skos:altLabel, skos:definition and the Concepts themselves.

carlschuurbiers commented 11 months ago

Just noticed this is partly duplicate of issue #128, sorry.

acka47 commented 11 months ago

Thanks for the request, @carlschuurbiers , and not problem with the additonal ticket. The indexing aof skos:altLabel is already covered with #128 so we can discuss the integration of skos:definition in the search (I've updaed the issue title). I am not sure whether this makes sense for alle the use cases. So we should make it configurable (@sroertgen has already implemented this in #185 ) and probably not set it as default.

I am leaving this ticket open for now. @sroertgen is developing SkoHub Vocabs and he will be back in two weeks. He may close this in favour of #128 then.

sroertgen commented 11 months ago

I just summarized this issue in #128 and will close this one.