search

skohub-io / skohub-vocabs

A lightweight tool to publish SKOS Vocabularies
https://skohub.io/
Apache License 2.0
32 stars 25 forks source link

161 search by notation #269

Closed sroertgen closed 10 months ago

sroertgen commented 10 months ago

The labels from

are now indexed. By selection of the respective label, only the relevant index gets loaded. This means we don't have one blown up index, but multiple for each label, which makes us handle even quite large vocabs performant. Also flexsearch has quite improved, so the index is not so big like before.

Re: Accessibility you are now able to check and uncheck boxes using Alt + <first letter of label e.g. Alt + a to toggle search for altLabels. Ctrl + k will you bring back to the search box.

Would like to know if the remaining labels i asked for in #128 should also be added. Since they will not blow up the index by default, I see no problem in doing so.

Will close #128 #161

sroertgen commented 10 months ago

The failing tests, I might handle in a separate issue. Everything goes through locally and I suspect some GitHub Action related issue, since sometimes one cypress test fails and sometimes two.

sroertgen commented 10 months ago

ok, I'm giving up with the cypress GitHub Action thing. Local tests work. I will disable this action for now and open an issue for it.

sroertgen commented 10 months ago

@acka47 you can test now, e.g. https://test.skohub.io/sroertgen/test-vocabs/heads/main/w3id.org/two-concepts-one-file/c1.de.html

or you can send your own vocab to the test-server

sroertgen commented 10 months ago

Telephone protocol: The searchable attributes should not be directly visible, but should be configurable inside a modal. The modal can be toggled by a button in the search box.

sroertgen commented 10 months ago

@acka47 please check again. Attributes are now set in a modal.

acka47 commented 10 months ago

This looks really good. One last UX thing: I find myself adjusting toggle buttons and then trying to click into the search window to start a search. This won't work at the moment and I have to go back to hit the "close" button first. There are two options for improvements:

  1. Do not require to hit the "close" button and also close the window when you click anywhere else.
  2. Remove the "close" button completely.
sroertgen commented 10 months ago

@acka47 Outside closing is now implemented. Please check again, e.g. https://test.skohub.io/sroertgen/test-vocabs/heads/main/w3id.org/two-concepts-one-file/c1.de.html