search

skohub-io / skohub-vocabs

A lightweight tool to publish SKOS Vocabularies
https://skohub.io/
Apache License 2.0
32 stars 25 forks source link

Problem with direct lookup of a concept #280

Closed acka47 closed 3 months ago

acka47 commented 7 months ago

The concept at question is https://test.skohub.io/hbz/lobid-vocabs/heads/master/nwbib.de/subjects.html#N448000

When I click through the hierarchy and go to this concept, everything is fine. Doing a direct lookup of the URL I get this:

image

This might well be an error in the concept scheme. However, if it breaks the application we should exclude such errors in the validation process.

acka47 commented 7 months ago

This might well be an error in the concept scheme.

Hmm, it doesn't look wrong to me: https://github.com/hbz/lobid-vocabs/blob/57ae3ed05324d57452fc2a3a7bee04adb3ca23e3/nwbib/nwbib.ttl#L2690-L2698

sroertgen commented 7 months ago

This is related to PR #279 The test system is already serving the current dev version without the language tags

sroertgen commented 7 months ago

@acka47 if you visit it the second time, does it work?

sroertgen commented 7 months ago

Will look into it. Maybe I have overlooked something regarding hash uris

acka47 commented 7 months ago

Investigating this further, there are neither skos:definition nor skos:scopeNote shown although they are in the SKOS file, see https://github.com/hbz/lobid-vocabs/blob/57ae3ed05324d57452fc2a3a7bee04adb3ca23e3/nwbib/nwbib.ttl#L2690-L2698

Instead it reads:

No scope note in language "undefined" provided.

This applies to all other concepts withscopeNote or definition, see e.g. https://test.skohub.io/hbz/lobid-vocabs/heads/master/nwbib.de/subjects.html#N124000 or https://test.skohub.io/hbz/lobid-vocabs/heads/master/nwbib.de/subjects.html#N865020

Apparently, this is a problem with https://github.com/skohub-io/skohub-vocabs/pull/279, so this should be considered as part of the review of #279.

acka47 commented 7 months ago

if you visit it the second time, does it work?

Yes, in the sense that there is no error message, no in the sense that definition and scopeNote are not shown.

sroertgen commented 7 months ago

@acka47 title, definition, scope note etc should now be working again after a rebuilt of the vocabs. What I still have to investigate: If a hashURI concept is visited directly you first see the concept scheme and need to reload to see the concept, e.g. https://test.skohub.io/sroertgen/test-vocabs/heads/main/nwbib.de/subjects.html#N841000

sroertgen commented 7 months ago

The before mentioned problem should now also be fixed. If you rebuild, the vocab should behave like expected again

sroertgen commented 3 months ago

@acka47 Is this still an issue? Direct lookup of concepts seem to be working.

acka47 commented 3 months ago

I think this was fixed some time ago and works now like a charme: https://skohub.io/hbz/lobid-vocabs/heads/testingSkoHub/nwbib.de/subjects.html#N448000

Closing.