search

skohub-io / skohub-vocabs

A lightweight tool to publish SKOS Vocabularies
https://skohub.io/
Apache License 2.0
34 stars 25 forks source link

Add "inbox" and "followers" to JSON-LD context #88

Closed acka47 closed 4 years ago

acka47 commented 4 years ago

Fixes https://github.com/hbz/skohub-vocabs/issues/87

acka47 commented 4 years ago

I think there is something wring with the test infrastructure. All tests fail to run with this message:

Test suite failed to run

[BABEL] /home/runner/work/skohub-vocabs/skohub-vocabs/test/{test}.test.js: Cannot find module '@babel/compat-data/corejs3-shipped-proposals'

Please help, @literarymachine .

dr0i commented 4 years ago

I think we can fix it leaving @literarymachine in parental leave ... To begin with, it npm test works on our machines even using your branch (one must stop the skohub-vocabs daemon, though, for the test instance uses the same port when testing webHookServer. TODO: document this). Second, e.g. laravel needs a newer babel/preset-env lib ,which may be installed on the github test environment. We use <v7.9.

dr0i commented 4 years ago

@acka47 as the last commit fixed the github test - ping if this PR ready to be merged and deployed.

acka47 commented 4 years ago

+1 Please merge and deploy

dr0i commented 4 years ago

Merged and deployed, but see #87 for further questions.