search

skolodyazhnyy / symfony-rpc-bundle

Simple JSON and XML RPC Server/Client implementation for Symfony 2
MIT License
25 stars 22 forks source link

Schema xmlrpc.xsd #11

Closed benisteel closed 9 years ago

benisteel commented 9 years ago

HI. I would like to know if it's normal if there are a Base64 tag ( with B ) in the schema xmlrpc.xsd. The response in base64 doesn't decode and i have an null response with an other software. Thanks

Best regards.

benisteel commented 9 years ago

Hi. I really need to know if it's normal. Because i must modify your xmlrpc.xsd for a good xmlrpc communication. You can see in your file https://github.com/skolodyazhnyy/symfony-rpc-bundle/blob/master/XmlRpc/Implementation.php that you use a base64 tag and not Base64 tag. Thanks for your help.

benisteel commented 9 years ago

I would like specify that the base64 is in line 229 of your file https://github.com/skolodyazhnyy/symfony-rpc-bundle/blob/master/XmlRpc/Implementation.php

Thanks again.

skolodyazhnyy commented 9 years ago

Hey, thanks for your report I have fixed it in master branch. Now node name are case insensitive in Implementation.php and both base64 and Base64 are valid nodes

benisteel commented 9 years ago

Thanks for your response. Can you add in your implementation.php file the XML-RPC specification " If no type is indicated, the type is string."

Thanks a lot.

benisteel commented 9 years ago

Hi Sergey. Is it possible to add this spec (http://xmlrpc.scripting.com/spec.html) in your implementation.php file . When there is no tag, you get text from xml-rpc communication like a string. Then we are and "by default".

Thanks.

benisteel commented 9 years ago

Hi Sergey. Think about my issue

skolodyazhnyy commented 9 years ago

Don't worry, if you need it to be done quickly you always can use fork-commit-pull-request thing ;) https://guides.github.com/introduction/flow/index.html

benisteel commented 9 years ago

Hi Sergey. i'm not worried, i would like to tell you that your bundle is great and will be perfect if you include this spec in your code. I can wait, no problem. I close this issue. Thanks