search

skonves / express-http-context

Get and set request-scoped context anywhere
MIT License
299 stars 26 forks source link

Expose namespace to allow apply patches to it #20

Closed DontRelaX closed 5 years ago

DontRelaX commented 6 years ago

cls-hooked do not work out of box with bluebird (https://github.com/Jeff-Lewis/cls-hooked/issues/16) Suggested solution is to use (https://github.com/TimBeyer/cls-bluebird) that require access to namespace. So this change allow to patch namespace that was internally created by express-http-context

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-100.0%) to 0.0% when pulling a59387343399fea6a0db8edc6530acc14b70fd2d on DontRelaX:expose-namespace into 34c8ed11d2af54675c9a0cf0f2b9c305135c5185 on skonves:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-100.0%) to 0.0% when pulling a59387343399fea6a0db8edc6530acc14b70fd2d on DontRelaX:expose-namespace into 34c8ed11d2af54675c9a0cf0f2b9c305135c5185 on skonves:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-100.0%) to 0.0% when pulling a59387343399fea6a0db8edc6530acc14b70fd2d on DontRelaX:expose-namespace into 34c8ed11d2af54675c9a0cf0f2b9c305135c5185 on skonves:master.

skonves commented 5 years ago

Thanks for contributing! This looks really good! :+1:

And I apologize for taking so long to review it. I'll be publishing an updated package later today or tomorrow.

skonves commented 5 years ago

Published in v1.1.0