search

skonves / express-http-context

Get and set request-scoped context anywhere
MIT License
299 stars 26 forks source link

fix: add cls-hooked types as dependency #37

Closed SimenB closed 5 years ago

SimenB commented 5 years ago

To fix this:

image

While I did not get an express type error, that's because I had it installed myself (which I suppose most people have if using this module and TS). However, it's still preferable to include all used dependencies

https://github.com/skonves/express-http-context/blob/26a22eb04795f9c2d52807208381635d66010ae8/index.d.ts#L1

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 935882ab28f9dd1a19ea424bfb6664d986187891 on SimenB:patch-1 into 26a22eb04795f9c2d52807208381635d66010ae8 on skonves:master.

skonves commented 5 years ago

Thanks!