search

skooner-k8s / skooner

Simple Kubernetes real-time dashboard and management.
http://skooner.io/
Apache License 2.0
1.33k stars 181 forks source link

Does Skooner support OIDC PKCE Auth #406

Open rajakshay opened 1 year ago

rajakshay commented 1 year ago

Hello Skooner Team,

Is PKCE Auth Supported in Skooner?

I have gone through the doc: https://github.com/skooner-k8s/skooner#oidc And the option of using OIDC_METADATA. But, looks like there is no option to choose PKCE in the client metadata: https://github.com/panva/node-openid-client/blob/main/docs/README.md#new-clientmetadata-jwks-options

And the option to do that would be in https://github.com/panva/node-openid-client/blob/main/docs/README.md#clientauthorizationurlparameters by setting code_challenge_method: 'S256', but there isn't an option to do that in skooner code: https://github.com/skooner-k8s/skooner/blob/ccbda174d55b9cec14aabe8f60fd4bce41531780/server/index.js#LL133C5-L133C60

Is there a plan on the roadmap to add this? If this is already supported in another way, a link to doc would help. Thanks.

tianni4104 commented 1 year ago

@rajakshay Thanks for sharing your thoughts. I don't think we have a plan to add it so far. We're happy to accept contributions if anyone is interested.

yuqiuw commented 1 year ago

Try fixing in https://github.com/skooner-k8s/skooner/pull/411

yuqiuw commented 1 year ago

https://github.com/skooner-k8s/skooner/pull/414