Adding new APIs and other improvements

skorokithakis / A6lib

An ESP8266/Arduino library for communicating with the A6 GSM module. ⛺

MIT License

127 stars 49 forks source link

Adding new APIs and other improvements #36

Closed IMAN4K closed 5 years ago

IMAN4K commented 6 years ago

I know this is going to be hard and time consuming to review :) But chill out and review changes step by step.

Mainly There are:

New Doxyfile
New dir separation (src, docs, examples)
New APIs mostly for SMS
Some new typo changes for implying meaningful actions
Added callbacks for SMS notifications
Making A6lib non-blocking by adding new callback handler (acts like the delay() in ESP)

skorokithakis commented 6 years ago

Thank you! Hmm, instead of git mv you deleted the old file and added the new one, which completely broke the diffs. Can you use git mv on the files so the diffs will show up correctly?

skorokithakis commented 6 years ago

I will try to review this, unfortunately my C++ isn't good enough for it, but hopefully I can make a pass. Thanks for your contribution!