search

skorokithakis / catt

Cast All The Things allows you to send videos from many, many online sources to your Chromecast.
BSD 2-Clause "Simplified" License
3.32k stars 153 forks source link

Vorbis / Opus load fine, incorrect error message #389

Open chapmanjacobd opened 2 years ago

chapmanjacobd commented 2 years ago

I get an error but the files are supported and they indeed play fine via catt in practice, even though it says they are video/mp4

for file in (fd . ~/d/80_Now_Listening/ -tf | shuf -n50)
    catt cast "$file"
end

Casting local file /root/d/80_Now_Listening/Peao.opus...
Playing "Peao" on "Xylo and Orchestra"...
Serving local file(s).
192.168.1.112 - - [24/Feb/2022 14:19:21] "GET /?loaded_from_catt HTTP/1.1" 206 - video/mp4 - 2.98 MB
Device disconnected while playing. Please check that the video file is compatible with the device.
192.168.1.112 - - [24/Feb/2022 14:19:22] "GET /?loaded_from_catt HTTP/1.1" 206 - video/mp4 - 2.98 MB
192.168.1.112 - - [24/Feb/2022 14:19:22] "GET /?loaded_from_catt HTTP/1.1" 206 - video/mp4 - 2.98 MB
[Casting local file /root/d/80_Now_Listening/Johannes_Hieronymus_Kapsberger-Arpeggiata_addio.opus...
Playing "Johannes_Hieronymus_Kapsberger-Arpeggiata_addio" on "Xylo and Orchestra"...
Serving local file(s).
192.168.1.112 - - [24/Feb/2022 14:22:36] "GET /?loaded_from_catt HTTP/1.1" 206 - video/mp4 - 6.68 MB
Device disconnected while playing. Please check that the video file is compatible with the device.
192.168.1.112 - - [24/Feb/2022 14:22:36] "GET /?loaded_from_catt HTTP/1.1" 206 - video/mp4 - 6.68 MB
192.168.1.112 - - [24/Feb/2022 14:22:36] "GET /?loaded_from_catt HTTP/1.1" 206 - video/mp4 - 6.68 MB
192.168.1.112 - - [24/Feb/2022 14:22:37] "GET /?loaded_from_catt HTTP/1.1" 206 - video/mp4 - 6.68 MB

sequential playing works great 👍

This error is incorrect:

Device disconnected while playing. Please check that the video file is compatible with the device.
skorokithakis commented 2 years ago

Yeah, that will sometimes happen because the CC disconnects and we can't tell if it did because it doesn't want to play or for other reasons. There isn't really much we could do, other than reword the message.

chapmanjacobd commented 2 years ago

hmmm okay

saying "The video file might not be compatible with the device." sounds a bit more truthful than "Please check that the video file is compatible with the device." even though both convey the same meaning

It's interesting that even though CC disconnects you are still able to know when the file stops playing. No complaints.. just glad it works ~!

skorokithakis commented 2 years ago

Hm yeah, that wording might be better, we can change it. What do you mean by "know when the file stops playing"?

chapmanjacobd commented 1 year ago

know when the file stops playing

I just mean that catt stays open until the end of the song. so not sure where that error message comes from if catt knows when the song is over. I think it's still communicating with the CC device even though it prints that error message