Closed avamsi closed 7 years ago
Ah, sorry, I just saw this now. I'm afraid I don't have a Windows machine, but any PRs for this would be welcome!
It seems that this is resolved with #7. Should this be closed now?
I can confirm tbvaccine works fine on Windows 10 x64
Yep, thank you! Can I ask how you found TBVaccine? I'm getting lots of comments today.
@skorokithakis I have noticed your issue with a suggestion of merge with better-exceptions project on their issue tracker, and since I have had an issue with better-exceptions working with Dask Distributed, I decided to give TBVaccine a try. BTW, TBVaccine worked OK, though the extra information doesn't seem to be sane/helpful #11.
I see, thank you! I'll get to #11 soon, although I don't use Distributed, so if you could take a look and see why it might be reporting weirdness, it would really help.
@skorokithakis Unfortunately, I don't have time at the moment, and to be honest, it is not a showstopper for me, so I am not sure I will be able to spend some time on digging into it soon. I reported the bug only with a hope that it will help you to improve TBVaccine (it might be that Dask case is not very specific and it only helped to identify a potential problem).
Cheers!
Ah, that's fine, thank you. The exception-getting code is pretty straightforward, so I don't think it's a general problem. It's more likely that Dask is doing something weird with exceptions, but I'll have a look anyway, just in case.
This may be as simple as importing and initializing colorama.