Add TBVACCINE_FORCE for non-isatty stderr

skorokithakis / tbvaccine

A small utility to pretty-print Python tracebacks. ⛺

MIT License

377 stars 14 forks source link

Add TBVACCINE_FORCE for non-isatty stderr #29

Closed wataash closed 4 years ago

wataash commented 4 years ago

Closes #28

Ref.

better-exceptions: FORCE_COLOR
logzero: LOGZERO_FORCE_COLOR

skorokithakis commented 4 years ago

This looks good but I think you should have to enable both TBVACCINE and TBVACCINE_FORCE to get the desired behaviour. One enables the library, the other forces it always.

wataash commented 4 years ago

:+1:

skorokithakis commented 4 years ago

For some reason, Github is not sending me notifications emails even though I am subscribed, sorry this took so long.

Do you want to update this so we can merge?

wataash commented 4 years ago

No problem, it's not your fault, just due to my slow activity... sorry. Yes, I'll update this. (hopefully today)

wataash commented 4 years ago

Sorry for late action, it's now ready to review.

skorokithakis commented 4 years ago

Thank you, it's almost good to go!

wataash commented 4 years ago

@skorokithakis How is it?

skorokithakis commented 4 years ago

Sorry, this looks good!

skorokithakis commented 4 years ago

Merged, thank you and sorry for the delay!