search

skorokithakis / tbvaccine

A small utility to pretty-print Python tracebacks. ⛺
MIT License
377 stars 14 forks source link

Hooked by TBVACCINE=0 is confusing #34

Closed wataash closed 4 years ago

wataash commented 4 years ago

README says export TBVACCINE=1 hooks tbvaccine, so I expected export TBVACCINE=0 would not hook, but it did. I think the hook should be done only if TBVACCINE is exactly 1. (but that's a breaking change...)

skorokithakis commented 4 years ago

You are correct, we should do this. If someone set TBVACCINE to anything other than 1 to enable it, that's undocumented, and we don't have to support it.