search

skorokithakis / tbvaccine

A small utility to pretty-print Python tracebacks. ⛺
MIT License
377 stars 14 forks source link

Simplify isatty #35

Closed wataash closed 4 years ago

wataash commented 4 years ago

IOBase.stderr() has existed from at latest Python 2.7.4 and 3.1 (https://github.com/python/cpython/commit/4fa88fa0b), so sys.stderr.isatty() likely exists.

skorokithakis commented 4 years ago

Hmm, I'm torn on this. On one hand, you're right, it's very likely to exist. On the other hand, the extra bit of code doesn't hurt anything, and I don't want this to break even for one person for such small savings...

wataash commented 4 years ago

Thanks for sharing your thoughts, I understood :+1:

wataash commented 4 years ago

I'm torn on this.

Oops, I overlooked this :) I'll reopen this PR if you want.