Closed XuluWarrior closed 5 years ago
Hey @XuluWarrior thanks for the issue / PR - I don't think I have notifications set up properly for this repository.
My feeling right now is that I'd prefer selectorGraph()
to output pure a JSON dict (or string, if we need to) Any reason you decided to make the change in the extension rather than in the lib?
I actually originally made changes in the lib but then thought that perhaps the intention of selectorGraph was to return the actual selector values rather than reflections of them. It would then be up to the consumer of the graph as to how to use/format it.
As my only current use of the lib is to show the results in the extension, I don't mind where the change is.
Yeah I think I'm sold on having it here.
Is it implemented? I still see internal structure of Immutable objects in Reselect Devtools Exension@0.0.2 + reselect-tools@^0.0.7.
It doesn't look like it. My PR hasn't been merged yet.
@XuluWarrior wasn't it decided to have this been fixed in the extension?
@anikolaev my PR (#4) is for the extension
@XuluWarrior Oh, I see now. I first thought you are the owner of the extension repo.
@skortchmark9 could we have this merged?
Merged now. Sorry about the delay I've been doing other things.
Moving all extension issues into the main repo, per #24
Currently, if a selector outputs Immutable values these are shown in the state tree in their rawest object form e.g.
Immutable.Map({a:1})
becomesrather than