skoruba / Duende.IdentityServer.Admin

The administration for the Duende IdentityServer and Asp.Net Core Identity ⚡
Apache License 2.0
556 stars 194 forks source link

Configure GitHub as external provider #72

Open erossini-chi opened 2 years ago

erossini-chi commented 2 years ago

Hi guys, I have just configured and replace my old Skoruba with the new one. Thank you for your great job! I'm fighting with the configuration of GitHub. First, in the configuration

  "ExternalProvidersConfiguration": {
    "UseGitHubProvider": false,
    "GitHubClientId": "",
    "GitHubClientSecret": "",
    "UseAzureAdProvider": false,
    "AzureAdClientId": "",
    "AzureAdTenantId": "",
    "AzureInstance": "",
    "AzureAdSecret": "",
    "AzureAdCallbackPath": "",
    "AzureDomain": ""
  }

there is a value misses GitHubCallbackPath. So, I think you can change the configuration in

  "ExternalProvidersConfiguration": {
    "UseGitHubProvider": false,
    "GitHubClientId": "",
    "GitHubClientSecret": "",
    "GitHubCallbackPath": "",
    "UseAzureAdProvider": false,
    "AzureAdClientId": "",
    "AzureAdTenantId": "",
    "AzureInstance": "",
    "AzureAdSecret": "",
    "AzureAdCallbackPath": "",
    "AzureDomain": ""
  }

My question is about the callback. I tried different path

but none of them is working. What is the correct path I have to use?

Thank you in advance Enrico

erossini commented 2 years ago

You have to use

/signin-github-token

You can see my post.

Zhy946644 commented 2 years ago

You have to use

/signin-github-token

You can see my post.

Hi, I'm having the same problem. But the platform I'm using is WeChat and I don't know what CallbackPath needs to be filled in. So, I'd like to ask you where to look or where to check, thanks,Looking forward to hearing from you! image

workcontrolgit commented 1 year ago

I published a blog on how to connect to GitHub, Facebook, Google, Microsoft, and Twitter. For GitHub, set up the “https://localhost:44310/signin-github” as the Authorization callback URL in GitHub developer console.