skosch / Crimson

The Crimson Text typeface
SIL Open Font License 1.1
527 stars 55 forks source link

Intersecting paths in some glyphs may cause improper rendering #10

Open thebodzio opened 9 years ago

thebodzio commented 9 years ago

I noticed that some glyphs in this font are constructed from referenced glyph and path crossing that glyph. Unfortunately, this may cause problems with their rendering. As I checked, freetype2 seemd to render mentioned glyphs as intended, however Windows XP at some sizes displayed empty areas where the shapes intersected. Below is illustration of this issue.

crimson-text-problem

So far I noticed this problem with the following glyphs: /oslash, /Oslas, /dcroat, /Dcroat, /lslash and /Lslash. Full list can be obtained thanks to FF's “Find problems…”. One way to fix this would be to simply “place” the reference in the given glyph and use “Remove Overlap”. I didn't do it myself because a) time, b) I didn't know if that's the smartest way to do it (don't know if, by a chance, FF can do that automatically when it generates binary file).

adrientetar commented 9 years ago

They need to be marked as "Remove overlap in generated files" from the Glyph Info menu. I'll take care of that and tag a new release.

thebodzio commented 9 years ago

Thank you! That's exactly why I prefer to ask first and “shoot” later ;)

adrientetar commented 9 years ago

I fixed the regular weight in the tree (actually there is a lot of positioning/duplicates problems with glyphs that have two stacked accents).

thebodzio commented 9 years ago

Thanks again! I've seen those problems in report too, but the one I raised is IMHO most visible.

ghost commented 9 years ago

I'm afraid the bug is still there, but only in OTF version.

bug

katef commented 8 years ago

I don't have a Windows machine, but I asked a friend to confirm this bug, using a fresh build of Crimson-Roman.otf from around ca492c6 or so. He says ł and Ł render fine in Windows 7.

@NumericalEvolution @thebodzio can you confirm that this still exists by generating an up to date OTF file? Which version of Windows are you using? I'd like to be able to reproduce this.

thebodzio commented 8 years ago

As for me, for day-to-day use I'm running Linux, but for the rare cases when I have to use Windows, I'm using an ancient XP. Anyway…

I've built OTF from ca492c6 and it appears to work all right in both Linux and XP. The version that didn't work (in Windows XP at least) was the one from the “Desktop Fonts” folder in the repo.

adrientetar commented 8 years ago

I have fixed some of the overlaps in the regular weight but they are numerous (so many diacritics were generated in the font).

katef commented 8 years ago

@adrientetar How do you fix that sort of thing? Is it just a case of changing the direction for the outline?

skosch commented 8 years ago

Fontforge has a validation tool, but I remember being unable to silence many of the warnings even after fixing what seemed to be the underlying problems, so I gave up eventually (this is a few years back). It's likely that there are still a whole bunch of reversed outlines, but I'm also on Linux and haven't had problems.

adrientetar commented 8 years ago

@katef Right-click on glyph > properties and you have a checkbox "remove overlap when generating"

katef commented 8 years ago

@adrientetar Thanks!