skosch / Crimson

The Crimson Text typeface
SIL Open Font License 1.1
518 stars 55 forks source link

Ligatures for italic #18

Closed katef closed 8 years ago

katef commented 8 years ago

The italic face puts "fi" awfully close together, and these would suit a ligature to give a less cluttered feel. I didn't check, but I suspect the same would be true for the other usual ligatures, fl, ffi and such.

Thank you,

katef commented 8 years ago

@skosch pointed out that there exists a f_i ligature at U+FB01. It looks like the current substitutions for the liga feature map fi to substitute literally f i. I suppose those are there as a handy placeholder. So my request is to have those substitute f_i instead.

I'd offer a patch, but for some reason my fontforge is showing most (but not all!) glyphs as blank, and that's true when I generate an otf font, too. So I can't test that. But here's all I did:

-Ligature2: "'liga' Ligatures standard lookups5-1" f i
+Ligature2: "'liga' Ligatures standard lookups5-1" f_i
ghost commented 8 years ago

This also happens for italic "ch" pic.

skosch commented 8 years ago

@NumericalEvolution are you using an old (i.e. Google's) version? @katef Thanks for trying :) I'll look into it later today!

ghost commented 8 years ago

@skosch I use the one provided by Adobe Edge Fonts. As I understand, it's fixed now?

katef commented 8 years ago

@NumericalEvolution Yes - the ch spacing looks fixed to me, for the current version from git.

katef commented 8 years ago

Oh, had someone already committed this? I must've been confused! The current revision seems to have fi and similar present for the liga feature for the Italic face.

I'm going to mark it closed. False alarm :)