search

skosch / Crimson

The Crimson Text typeface
SIL Open Font License 1.1
520 stars 55 forks source link

accent positions in latest binaries #61

Open m4rc1e opened 7 years ago

m4rc1e commented 7 years ago

I'm in the process of updating this family on Google Fonts. Unfortunately, many glyphs have had their accents shifted incorrectly, when compared to the current version hosted on GF

crimsontext

I see you've been updating the project to use fontmake. I'd far rather update the GF version once we can successfully use fontmake on this project.

cc @davelab6

skosch commented 7 years ago

@m4rc1e First off, hooray! :tada: People have been bugging me for years about the Github/GF divergence, so I'm really happy you guys have finally worked your way down the list to little ol' Crimson!

Frankly, I'm swamped with my day job right now – life of a freelancer! – and won't be able to invest the time to clean this up for the next few weeks at least. The biggest difference between the ufo and master branches is that in the ufo branch, most of the OpenType features, incl. kerning, have been semi-manually fixed (though they're not perfect). There are still issues with accent positions, vertical metrics etc.

Is there anything I can do in the meantime to help you guys move this forward?

davelab6 commented 7 years ago

@skosch i think if you are happy for us to just take care of this, we can come up with a PR for you to review and approve that sorts everything out, while you are busy

skosch commented 7 years ago

100% happy to let you guys do whatever. You're the experts!

davelab6 commented 7 years ago

Okay cool - while marc and other font engineers sort out out the more technical issues, I also have @fonthausen around to help with type design issues. They'll both take a look within the next week or two and provide a summary of the differences (similar to the screenshot above)

skosch commented 7 years ago

Also, @Fonthausen you worked some impressive magic on Nunito and Pacifico – I don't know what budget you've been given, but if you want to give Crimson a facelift consider yourself at full artistic liberty :-)

Fonthausen commented 7 years ago

@skosch Thank you for the compliment ! :) I'll try to do my best !

I found .sfd files in the source folder. Would it be possible for you to generate UFO or glyphs files ?

skosch commented 7 years ago

Check out the ufo branch (literally lol). Would those work for you?

Fonthausen commented 7 years ago

UFO should do the work. I will have a look if all work as expected. Thanks

m4rc1e commented 6 years ago

Looks like I found this issue again :-)

I was going to release an update on GF to resolve https://github.com/google/fonts/issues/1424. However, I feel the newer version has even more glyph design issues. We have missing glyphs, glyphs using base glyphs as mark glyphs and mispositioned accents.

We've improved our tools slighly at the end of last year so we can now gif diff complete fonts. Here's a diff gif against the current fonts vs the fonts hosted on GF

desktop_os_x_el_capitan_safari_9 1_

I hope this makes things clearer.