skosch / Crimson

The Crimson Text typeface
SIL Open Font License 1.1
518 stars 55 forks source link

Updated specimen with more combinations and all accented Slovak letters. #7

Closed LRjunior closed 10 years ago

LRjunior commented 10 years ago

I found in small caps that for letter ť in small caps its caron is not of correct shape, it should be placed as in Ť and not under T. See specimen and picture below. smallcaps

@skosch Could you please correct it?

LRjunior commented 10 years ago

I have noticed that shapes for small caps in BoldItalic, Semibold, and SemiboldItalic are not present.

LRjunior commented 10 years ago

My observations on specimen related to small caps. Š in Bold has not centered caron and small caps Ť caron is not centered too. Small caps Ľ caron need also corrections in Roman, Italics and Bold. also small caps Ď in Roman caron is not centered. Others seem to be OK.

skosch commented 10 years ago

Ladislav, if you want to make those changes, go ahead! :)

LRjunior commented 10 years ago

I have done all corrections I had mentioned on this page and small corrections to caron on Lcaron for Italics. See specimen.

skosch commented 10 years ago

The specimen is great! I'm just wondering why the commit includes 5 OTF files (the Semibold is absent). I'll happily merge, but you should be aware that those will be overwritten anyway when Adrien regenerates the binaries from the SFDs. Thanks again!

LRjunior commented 10 years ago

Semibold was not changed (so there was no need to generate new OTF) but SemiboldItalic was because of small correction of caron on Lcaron. (I was correcting this on all Italic, SemiboldItalic and BoldItalic)

skosch commented 10 years ago

Gotcha! Thanks Ladislav.

@adrientetar Unless something else comes up, you can generate the binaries now? :)