skosch / Crimson

The Crimson Text typeface
SIL Open Font License 1.1
518 stars 55 forks source link

Sinhala glyph set #9

Closed pathumego closed 9 years ago

pathumego commented 9 years ago

I'm looking for a matching latin set for this project - A Sinhala font for web. Found Crimson is working nicely. You can see the file here and test it with Sinhala+ Latin text here

screen shot 2014-11-16 at 2 19 44 am

adrientetar commented 9 years ago

@pathumego I just updated the dev branch, the license was only mentioned on the website.

(@skosch Would be cool to push the dev branch back into master now that I've finished the cleanups, it'd need a force push since I went over my previous PR.)

skosch commented 9 years ago

Cool, thanks! Frankly I'm a bit out of the loop wrt all the PRs, feel free to make whatever pushes necessary to bring the master up to date :)

adrientetar commented 9 years ago

Well, I don’t have the rights to force-push, I can only straight push.

skosch commented 9 years ago

Hm, interesting, I didn't realize that—out of curiosity, can't you checkout the dev branch and merge the changes into the master (as in this SO answer)? I'm happy to do that as well of course.

adrientetar commented 9 years ago

Since there are divergent commits from mine it'd need manual merging with a merge commit, force-pushing dev onto master would essentially yield something cleaner.

adrientetar commented 9 years ago

I see what the Stack Overflow answer tries to do, however it's when pushing to the remote that I need to overwrite, not locally. I can change the branches locally but that won't make it into the GitHub repo unless force-pushed.

skosch commented 9 years ago

Oh boy, what just happened? Did I delete the dev branch entirely?

adrientetar commented 9 years ago

Well I did that since you updated master.

skosch commented 9 years ago

Can you confirm that the master branch really did update?

adrientetar commented 9 years ago

Yes it has, it has my newer commits. (Thanks!)

skosch commented 9 years ago

Okay, that's a relief. I wasn't sure whether what I did was right. Thanks for your help!