search

skot / ESP-Miner

A bitcoin ASIC miner for the ESP32
GNU General Public License v3.0
309 stars 113 forks source link

No connection to wifis with SSID length of 32 bytes #218

Open kisenberg opened 3 months ago

kisenberg commented 3 months ago

Describe the bug If a wifi has a SSID with a length of 32 bytes, Bitaxe is not able to connect. Only connections to wifis with SSID up to a length of 31 bytes are possible.

To Reproduce Steps to reproduce the behavior:

  1. Go to AxeOS settings.
  2. Enter 32 bytes long SSID into field of "WiFi SSID".
  3. Click "Save".
  4. Click "Restart".
  5. Bitaxe displays try to connect the wifi forever.

Expected behavior A connection to wifis with SSID of 32 bytes length should be possible, because an SSID can be 32 bytes long.

Screenshots & Photos n/a

Hardware (please complete the following information):

Additional context n/a

tommywatson commented 3 months ago

Unfortunately it looks like we are limited to 31 characters by the esp-idf wifi libraries, the structure defined the ssid attribute as

uint8_t ssid[32]; /**< SSID of target AP. */

Including the null terminator that limits the SSID to 31 characters.

https://github.com/espressif/esp-idf/blob/8760e6d2a7e19913bc40675dd71f374bcd51b0ae/components/esp_wifi/include/esp_wifi_types_generic.h#L354

kisenberg commented 2 months ago

So, there will be no chance to change that from 32 bytes to 33 bytes with the null terminator?