While reviewing #471, noticed that json_rpc_buffer initialization tries to memset before checking if the malloc was successful.
This moves the memset after the check.
Did a basic test by building and running on a Supra 401. Started mining on testnet4 on a ckpool instance. Jobs were received and shares were accepted.
Note: The malloc failure is unlikely to occur, so we're not seeing an issue now, but if it does occur (e.g. other future code changes chew up too much heap), then we could actually see the error in the log.
While reviewing #471, noticed that
json_rpc_bufferinitialization tries tomemsetbefore checking if themallocwas successful.This moves the
memsetafter the check.Did a basic test by building and running on a Supra 401. Started mining on testnet4 on a ckpool instance. Jobs were received and shares were accepted.
Note: The malloc failure is unlikely to occur, so we're not seeing an issue now, but if it does occur (e.g. other future code changes chew up too much heap), then we could actually see the error in the log.