fix: Add restart to settings & better disabled state

skot / ESP-Miner

A bitcoin ASIC miner for the ESP32

GNU General Public License v3.0

370 stars 140 forks source link

fix: Add restart to settings & better disabled state #493

Closed mrv777 closed 8 hours ago

mrv777 commented 4 days ago

Description

Added the restart button to the settings page as requested here: #440
Also changed the disabled state so that save is only enabled if there are changes and restart only enabled if changes saved to prevent accidentally clicking that first

skot commented 1 day ago

The restart button is enabled after I click save, but it doesn't actually restart the Bitaxe when I click on it.

skot commented 1 day ago

I'd like to add this functionality to the network tab too 🙏

mrv777 commented 1 day ago

Sorry about that, simple fix. Should work now. I'll add it to the network tab later too

mrv777 commented 21 hours ago

PR updated @skot if you want to test when you get a chance. I tested the settings page, but haven't had a chance yet to upload the changes to a device again to test the network page changes

skot commented 8 hours ago

both settings and network work great! I think this is a huge usability improvement, very nice @mrv777