search

skotchvail / Love-Potion-Camp

Code related to the Burning Man camp called "Love Potion"
8 stars 3 forks source link

Adding keymap information to 2d/3d window. #17

Closed rdosser closed 11 years ago

rdosser commented 11 years ago

I've added inline descriptions of available key mappings to the 2d/3d display window. A set of default mappings are defined in TrancePorterIIProcessing.pde - since that's where the mapping is defined. HardwareTest.pde adds its own local mappings to those.

Maybe the mappings should be defined in Drawer instead?

skotchvail commented 11 years ago

This looks really good, thanks Ralph! I think this will be very useful. Watch the white space (one line is usually better than two). At some point I want to clean up the style of this code, which we inherited. It does not reflect good style, IMO. Also, I already have on my list to look at the hardware test and figure out why it is broken.

skotchvail commented 11 years ago

This fixes issue #3. I think that there is some way to have these automatically associated with each other, http://stackoverflow.com/a/7189981/1804403.

Maybe we have to say "fixes issue #3 " in the commit?

rdosser commented 11 years ago

Said it in the wrong place - sorry, I'm trying to do too much at once. So yes, next pull request I'll specify the issue it addresses.