Implement missing should.js transformations

skovhus / jest-codemods

Codemods for migrating to Jest https://github.com/facebook/jest 👾

MIT License

879 stars 82 forks source link

Open skovhus opened 6 years ago

skovhus commented 6 years ago

When converting webpack to Jest, jest-codemods failed on converting the should.js construct oneOf.

Let us go over the should.js transformer and see if there are more matchers that I missed.

[ ] expect(typeof id).to.be.oneOf("number", "string")
[ ] figure out if there are more matchers that are not supported by jest-codemods

niieani commented 6 years ago

I remember there were also quite a few false positives (where changes were made to code that shouldn't have been touched by the codemods).

skovhus commented 6 years ago

Let me know if you remember any examples of this.