skrafft / react-native-jitsi-meet

React native wrapper for Jitsi Meet SDK
Apache License 2.0
285 stars 348 forks source link

Jitsi crashes our app due to exclude group module #244

Open drinikol opened 3 years ago

drinikol commented 3 years ago

RN0.63.1 RN Jitsi meet : 2.1.1

Here is the problem we could build the app for release by excluding this modules but the jitsi crashes our app. But if we remove the exclude jitsi will work but only for debug. Is there a work around here?

implementation(project(':react-native-jitsi-meet')) {
       exclude group: 'com.facebook.react', module:'react-native-svg'
       exclude group: 'com.facebook.react', module:'react-native-community-async-storage'
       exclude group: 'com.facebook.react', module:'react-native-google-signin'
       exclude group: 'com.facebook.react', module:'react-native-vector-icons'
   }
Isbilbatua commented 3 years ago

Hi Drinikol!

I've been researching this library for a while and with a lot of problems when it comes to making a release.

Don´t remove excludes libraries, you must put them for release okay?

Steps that have worked for me.

1. Generate release bundle with this command (inside project):

mkdir -p android/app/src/main/assets && rm -rf android/app/build && react-native bundle --platform android --dev false --entry-file index.js --bundle-output android/app/src/main/assets/index.android.bundle --assets-dest android/app/src/main/res && cd android && ./gradlew assembleDebug

2. Delete "drawable" and "raw" libraries on Android project (App -> res)

3. Delete index.android.bundle App->Assets (VERY VERY IMPORTANT STEP)

4. Create release apk (build generated signed bundle )

GO GO GO!

alexandrtovmach commented 3 years ago

Check this https://github.com/skrafft/react-native-jitsi-meet/issues/251#issuecomment-791387438 for possible solution