Open aSemy opened 2 years ago
I've picked this back up again, but I've come across an issue with Kover. 0.5 had a bug https://github.com/Kotlin/kotlinx-kover/issues/183, and now 0.6 does too https://github.com/Kotlin/kotlinx-kover/issues/221
Hey awesome news you proceed working on the PR 🙏🚀 If kover is blocking the further development I think we can just proceed while waiting for a new kover release that hopefully includes a fix.
Is kover / make the gradle plugins work the last thing that is missing to finish the PR?
And big thanks again for your contribution 🔥 I really appreciate.
Apologies for the delay, and thanks for the nudge! :) I'll try and get this ready-for-review in the next couple of hours.
I've got an idea of how to fix Kover, so I'll give that a go. I've updated the main description with the TODOs.
Initial groundwork for Kotlin Multiplatform #192
Depends on #194
I was expect this to be a lot more difficult! I indended just to do one module, but I found that they were all very easy to migrate.
html-parser
was the most involved.That said, I can't run most of the tests (I'm on Windows), so I could have broken some stuff. And the really hard work of actually implementing JS and/or Native code can be done later.
WIP
Notes
expect
/actual
definitions - so check them out and see if they make sense. Theexpect
definitions are essentially like interfaces that the platform code will implement.HttpFetcher
andBrowserFetcher
objects are pretty redundant, as they don't significantly extend from theBlockingFetcher
interface. I think you can refactor the common code to only rely on the interface.