skrapeit / skrape.it

A Kotlin-based testing/scraping/parsing library providing the ability to analyze and extract data from HTML (server & client-side rendered). It places particular emphasis on ease of use and a high level of readability by providing an intuitive DSL. It aims to be a testing lib, but can also be used to scrape websites in a convenient fashion.
https://docs.skrape.it
MIT License
790 stars 57 forks source link

Initial Kotlin Multiplatform setup #196

Open aSemy opened 2 years ago

aSemy commented 2 years ago

Initial groundwork for Kotlin Multiplatform #192

Depends on #194

I was expect this to be a lot more difficult! I indended just to do one module, but I found that they were all very easy to migrate. html-parser was the most involved.

That said, I can't run most of the tests (I'm on Windows), so I could have broken some stuff. And the really hard work of actually implementing JS and/or Native code can be done later.

WIP

Notes

aSemy commented 1 year ago

I've picked this back up again, but I've come across an issue with Kover. 0.5 had a bug https://github.com/Kotlin/kotlinx-kover/issues/183, and now 0.6 does too https://github.com/Kotlin/kotlinx-kover/issues/221

christian-draeger commented 1 year ago

Hey awesome news you proceed working on the PR 🙏🚀 If kover is blocking the further development I think we can just proceed while waiting for a new kover release that hopefully includes a fix.

Is kover / make the gradle plugins work the last thing that is missing to finish the PR?

And big thanks again for your contribution 🔥 I really appreciate.

aSemy commented 1 year ago

Apologies for the delay, and thanks for the nudge! :) I'll try and get this ready-for-review in the next couple of hours.

I've got an idea of how to fix Kover, so I'll give that a go. I've updated the main description with the TODOs.