skrapeit / skrape.it

A Kotlin-based testing/scraping/parsing library providing the ability to analyze and extract data from HTML (server & client-side rendered). It places particular emphasis on ease of use and a high level of readability by providing an intuitive DSL. It aims to be a testing lib, but can also be used to scrape websites in a convenient fashion.

https://docs.skrape.it

MIT License

790 stars 57 forks source link

GitHub actions update #197

Closed aSemy closed 1 year ago

aSemy commented 2 years ago

update Gradle dependency caching
add concurrency cancellation
add timeout, just in case
disable fail-fast for test runs
update deprecated Windows OS https://github.com/actions/virtual-environments/issues/5238

I copied the concurrency config from here: https://docs.github.com/en/actions/examples/using-concurrency-expressions-and-a-test-matrix#understanding-the-example

I copied (and tweaked) the Gradle caching from https://github.com/JetBrains/intellij-platform-plugin-template/actions/runs/242898088/workflow#L46-L58

aSemy commented 2 years ago

The tests are failing because of the dependency on 0-SNAPSHOT versions

https://github.com/skrapeit/skrape.it/runs/7520692680?check_suite_focus=true#step:7:1075

I have similar problems when running locally. What's the best way to fix this?

christian-draeger commented 2 years ago

Hmm for some reason it looks like the 0-SNAPSHOT is not available. Since the example project that uses 0-SNAOSHOT just exists to showcase how to always pull latest snapshot from nexus staging repository we could pass latest released version for now to "fix" the problem but open an issue to understand why this happens and resolve it later. I am currently on vacation and only have my smartphone with me but I can investigate when I will be back.

I think it's OK to be pragmatic in this case since the error is just part of the examples module (a living documentation) and not of the library itself

aSemy commented 2 years ago

Thanks for the explanation! I'll do some Gradle magic. Enjoy your holiday!

codecov[bot] commented 1 year ago

Codecov Report

Merging #197 (77313b2) into master (6e809c1) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #197   +/-   ##
=======================================
  Coverage   82.85%   82.85%           
=======================================
  Files          38       38           
  Lines        1119     1119           
  Branches      173      173           
=======================================
  Hits          927      927           
  Misses        131      131           
  Partials       61       61

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.