skrapeit / skrape.it

A Kotlin-based testing/scraping/parsing library providing the ability to analyze and extract data from HTML (server & client-side rendered). It places particular emphasis on ease of use and a high level of readability by providing an intuitive DSL. It aims to be a testing lib, but can also be used to scrape websites in a convenient fashion.
https://docs.skrape.it
MIT License
813 stars 59 forks source link

Add logback configuration programatically to avoid failing projects with Spring Native #203

Closed marceligrabowski closed 2 years ago

marceligrabowski commented 2 years ago

201

I added LoggingConfiguration which is loaded using ServiceLoader to avoid having logback.xml in classpath Reference: https://logback.qos.ch/manual/configuration.html

If no custom Configurator was found, then DefaultJoranConfigurator. such file is found, is used to resolve the implementation of com.qos.logback.classic.spi.Configurator interface by looking up the file META-INF\services\ch.qos.logback.classic.spi.Configurator in the class path. Its contents should specify the fully qualified class name of the desired Configurator implementation.

codecov[bot] commented 2 years ago

Codecov Report

Merging #203 (bab4699) into master (b5ae623) will increase coverage by 0.32%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
+ Coverage   82.85%   83.16%   +0.32%     
==========================================
  Files          38       39       +1     
  Lines        1119     1140      +21     
  Branches      173      173              
==========================================
+ Hits          927      948      +21     
  Misses        131      131              
  Partials       61       61              
Impacted Files Coverage Δ
...n/it/skrape/fetcher/logging/LoggingConfigurator.kt 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

christian-draeger commented 2 years ago

thx for the great work :)