Closed linean closed 1 year ago
Merging #214 (2f53f97) into master (3958869) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #214 +/- ##
=======================================
Coverage 80.91% 80.91%
=======================================
Files 39 39
Lines 1168 1168
Branches 180 180
=======================================
Hits 945 945
Misses 162 162
Partials 61 61
Impacted Files | Coverage Δ | |
---|---|---|
...tcher/src/main/kotlin/it/skrape/fetcher/Scraper.kt | 80.96% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Thx for pointing this out :)
I've encountered a case where it would be helpful to use a suspend function directly from
SkrapeItDsl
.Here is a simplified example:
The above code won't compile because suspend functions cannot be called from the DSL. Looking at the source code I've noticed this limitation is caused by the missing suspend modifiers and could be easily changed.
It's easy to solve this problem by extracting suspend functions outside of the DSL and everything will work, but I thought I'll propose adding support to the DSL. Please tell me what you think.