skrapeit / skrape.it

A Kotlin-based testing/scraping/parsing library providing the ability to analyze and extract data from HTML (server & client-side rendered). It places particular emphasis on ease of use and a high level of readability by providing an intuitive DSL. It aims to be a testing lib, but can also be used to scrape websites in a convenient fashion.
https://docs.skrape.it
MIT License
790 stars 57 forks source link

Update kover and do a little clean up #230

Closed BarbieCue closed 11 months ago

BarbieCue commented 11 months ago

First I just wanted to clean up a bit :) That's why I created http-fetcher/extensions.kt to keep the structure aligned with async-fetcher's structure. And that is also why I removed some unused code.


Which projects are included in the merged coverage report? All except examples/* (see the root build.gradle.kts)

Merged Xml Report Will still be stored where the gradle pipeline expects it to be: ./build/reports/kover/report.xml

Merged Html Report Will no longer be created. Let me know if it is needed somewhere and I will add it again.

I did some tests but that doesn't mean that everything works as it should on the Gitlab CI server. Therefore, I gladly accept feedback and adjust again if necessary.

codecov[bot] commented 11 months ago

Codecov Report

Merging #230 (ccdc30e) into master (4926f42) will increase coverage by 5.84%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
+ Coverage   81.05%   86.88%   +5.84%     
==========================================
  Files          39       38       -1     
  Lines        1171      983     -188     
  Branches      180       88      -92     
==========================================
- Hits          949      854      -95     
+ Misses        161      100      -61     
+ Partials       61       29      -32     
Files Changed Coverage Δ
...r/src/main/kotlin/it/skrape/fetcher/HttpFetcher.kt 66.67% <ø> (+15.56%) :arrow_up:

... and 16 files with indirect coverage changes

christian-draeger commented 11 months ago

Hey Rene thx again for the work =) i am currently running out of time for open source because of family and job. help is very welcome 👍